Skip to content

Conversation

@marmor7
Copy link

@marmor7 marmor7 commented Nov 20, 2025

  • Added example code for file uploads and inline usage with Gemini GLA.
  • Clarified Google GLA file upload option

Update docs following PR:
#2270

I moved the Google GLA bullet above Google Vertex, because the inlined section that was vertex-specific did not seem inlined in the final doc, so it made the Google GLA bullet feel out of place:

Screenshot 2025-11-20 at 16 53 57

- Added example code for file uploads and inline usage with Gemini GLA.
- Clarified Google GLA file upload option
@dsfaccini
Copy link
Contributor

hey @marmor7 thank you for the PR, I left two comments on the code but wanted to give you some pointers as well

Firstly, you created the PR from the github UI, so you can't really review what your changes are gonna look like on the docs

  • it'd be advisable that you clone the repository and locally preview the docs after you've made changes to them, just as a sanity check

Secondly, your code examples use variables that aren't defined in the example. Generally, it's a good practice to provide examples that run "as is", i.e., the user can copy the example and run it without needing to find out, e.g., where the mimetype comes from. This would be caught by CI if the code blocks weren't marked to skip linting.

One thing in the example you provided for passing a file in-line, is you used the variable file_bytes, which may make people reading it think they need to file_bytes = Path('filepath.txt').read_bytes(), but if the google genai API expects a base64 encoded string, that's not going to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants